Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing requestAnimationFrame for effecincy #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxpert
Copy link

@maxpert maxpert commented Apr 26, 2011

requestAnimationFrame is known for giving you native animation framing from browser thus allowing benefits like device native framerates and battery saving; this patch makes emile requestAnimationFrame enabled making it even more freaking cool!

@didxga
Copy link

didxga commented Apr 27, 2011

Cool, Thumb Up.

@cmawhorter
Copy link

Nice

@peterp
Copy link

peterp commented Sep 22, 2011

Agreed.

@zorker
Copy link

zorker commented Jan 18, 2012

Actually this does not work if you have multiple animations running parallel.
Basically what happens if you have 2 animations running all the time (image tweens with random images for example) and additionally a third element with onmouseover, onclick and onmouseout event (animation on each event). If you hover the third element it will start the animation for the third element but all other elements freeze. Seems like only one animation is handled at a time.

If you got a workaround for that please let me know. Currently trying to fiddle that out myself.

@maxpert
Copy link
Author

maxpert commented Jan 18, 2012

Would be trying to reproduce your bug

@zorker
Copy link

zorker commented Jan 18, 2012

I fixed it for me. Gonna post my fork in a minute.

Here we go: https://github.com/zorker/emile/blob/master/emile.js

I added opacity handling and animation processing aswell.

@getdave
Copy link

getdave commented Aug 9, 2013

@madrobby Just checking in to see whether this ever got merged. Don't think so from the look of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants